docs: CLAUDE.md §Phase status drain (#311–#326) + A-L label fix + 2 PR #326 §Gotchas#327
Merged
Merged
Conversation
…#326 §Gotchas Full docs-reviewer substance pass on CLAUDE.md → 5 MUST-FIX + 4 SHOULD-FIX, all fixed in one focused diff. CLAUDE.md only (+ INFLIGHT lockstep entry); no code / schema / compute / frontend change. MUST-FIX: - §Phase status "In flight" marked PR #312 (tasteful-motion) as "THIS PR"; it merged as e602485 → "No current in-flight PR". - §Phase status "Recently merged" was frozen at PR #310 (16 PRs stale) → refreshed to #303 → #326 with the 16 missing entries (#311–#326). - §Phase status "Next deliverables" listed Issue #67 flip as pending → DONE via PR #294 (USE_SECTOR_COE = True). - §Commands + §workflow_dispatch "Section A-H" → "Section A-L" (helper is A-L since PR #221). - §Cue table defense-layer-auditor "Section A-J" → "A-L". (Historical edgar-debugger narrative keeps its A..J legend — point-in-time record.) SHOULD-FIX: - §Stack "Phase 3b on this PR" → "(merged)"; edgartools 5.31 → 5.32. - §Gotchas compute/main.py line refs re-anchored (840→879 · 1965-66→2084-85 · 717→728 · 785→805 · 972→1025). - §Gotchas +2 entries for PR #326 invariants (sidebar data-rail↔globals.css pre-paint lockstep; AreaChart re-park debounce ≥300ms). Confirmed no drift: schema 0.10.11-phase4.6 · skills 46 · agents 19 · hooks 3. Edits verified via sentinel grep (6 old → 0, 5 new → 1). Lockstep via PHASE_STATUS_INFLIGHT.md side-file (PR #237 convention). https://claude.ai/code/session_0144kHrCYNaamMPH57b7xdM7
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…iewer SHOULD-FIX) The Recently-merged PR #316 entry substituted '(skill count 45 → 46)' for the commit's own '(original-prose, inspire-only)'. Both are true; keep both for commit-log fidelity per the docs-reviewer re-check note. https://claude.ai/code/session_0144kHrCYNaamMPH57b7xdM7
This was referenced May 31, 2026
dackclup
added a commit
that referenced
this pull request
May 31, 2026
…t + sign-aware MoS) (#333) PR #332 (stock-detail hero rework) merged as a fast spot-check-driven UI iteration and skipped the CLAUDE.md/AGENTS.md substance lockstep. Add the two invariants future editors must not regress: 1. The hero's two-column (name-left / stats-top-right) vs stacked decision is driven by a CSS CONTAINER QUERY on the hero's own inline-size, NOT a viewport md:/lg: breakpoint — because the sidebar eats a viewport-variable width slice (the dead-band bug that prompted the rework). JSX default is the stacked flex-col; @container only adds the row; raw CSS, no plugin/dep. 2. The MoS gauge arc is sign-aware: >=0 clockwise (like the score gauge), <0 counter-clockwise via -scale-x-100 on the container with the number span mirrored back. 329/502 of the universe is negative, so CCW is the common case. CLAUDE.md §Gotchas holds the full rationale; AGENTS.md §Code style mirrors each as a pointer (PR #327 precedent). PHASE_STATUS_INFLIGHT.md entry per the ship-with-every-PR convention. Doc-only — the hero code already shipped in #332. https://claude.ai/code/session_0148EoMmL6zakDWqHXjqQ9yq Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full
docs-reviewersubstance pass onCLAUDE.mdsurfaced 5 MUST-FIX + 4 SHOULD-FIX — all fixed here in one focused diff.CLAUDE.mdonly (+ aPHASE_STATUS_INFLIGHT.mdlockstep entry); no code / schema / compute / frontend change.MUST-FIX (factual errors / contradictions that would mislead a future agent)
e602485. → "No current in-flight PR on this branch" + pointer to the side-file.PR #303 → PR #326+ the 16 missing entries (docs: reconcile cross-doc drift after the 6-PR session (#303–#310) #311–fix(frontend): sidebar refresh/rotate flash + chart crosshair re-park on sidebar toggle; 2 flaky-test guards #326) inserted newest-first with SHAs.USE_SECTOR_COE = Truealready flipped via PR feat(valuation): Issue #67 — flip USE_SECTOR_COE True (Damodaran 11-sector Ke) #294 (config.pyconfirms). → "Issue Phase 5+: Damodaran sector-adjusted cost_of_equity (deferred from Phase 4c) #67 — DONE (PR feat(valuation): Issue #67 — flip USE_SECTOR_COE True (Damodaran 11-sector Ke) #294)".A=…/…/J=annotate inventorylegend — a point-in-time 4.5-era record, preserved per the doc's historical-narrative convention.)SHOULD-FIX (staleness)
compute/main.pyline refs re-anchored to the current file: 840→879 · 1965-1966→2084-2085 · 717→728 · 785→805 · 972→1025.PHASE_STATUS_INFLIGHT.md): (a) Sidebardata-railattrs ↔globals.csshtml.sidebar-collapsed [data-rail=…]pre-paint rules move in lockstep (drift → refresh text-flash returns); (b) the price-chart crosshair re-park MUST debounce the<AreaChart>remount ≥ ~300ms so it lands afterResponsiveContainerre-measures (immediate remount → crosshair parks at index 0 / far-left).5.31→5.32(installed version).Confirmed NO drift (no change needed)
schema
0.10.11-phase4.6(config.py) · skills 46 · agents 19 · hooks 3 · defense-layer 33 declared — all §Layout counts already accurate. No broken cross-links.Verification
Markdown-only — no ruff / pytest / build surface. Edits verified via sentinel grep: all 6 old strings → 0 occurrences, all 5 new strings → 1. Only 2 files changed (
CLAUDE.md49+/17−,PHASE_STATUS_INFLIGHT.md89+/0− append).docs-reviewerre-check spawned at this gate. Lockstep satisfied via thePHASE_STATUS_INFLIGHT.mdside-file (PR #237 convention); AGENTS.md mirror of the 2 frontend gotchas deferred (they live in CLAUDE.md §Gotchas, the canonical home; AGENTS.md carries no §Gotchas mirror today).https://claude.ai/code/session_0144kHrCYNaamMPH57b7xdM7
Generated by Claude Code