added unknown weather record for failure to retrieve

[dacracot]

No description provided.

[greptile-apps]

Greptile Summary

This PR enhances error handling and logging for external API failures in the BirdNET-BarChart system. The changes address two critical failure scenarios: celestial data retrieval from the US Naval Observatory API and weather data retrieval from OpenWeatherMap API.

In daily.sh, the modification adds improved logging for celestial data retrieval failures. When the celestial API call fails, the system now logs "celestial fail on attempt ${i}" and includes documentation explaining that complete failures are ignored since subsequent queries can retrieve the last successful data. This change improves debugging capabilities without altering the existing failure handling strategy.

In hourly.sh, the change implements a more robust fallback mechanism for weather API failures. When all 5 retry attempts to retrieve weather data fail, the system now inserts an "unknown" weather record into the database instead of leaving a gap. This prevents the web interface's JavaScript dial component from breaking, as it expects weather data to be present at specific hourly intervals (00, 03, 06, 09, 12, 15, 18, 21). The fallback record uses appropriate placeholder values: 'unknown' for condition, 0 for iconNumber, and '-' for numeric fields like temperature and humidity.

Both changes integrate well with the existing codebase architecture. The BirdNET-BarChart system relies heavily on external APIs for environmental context data, and these modifications make the system more resilient to third-party service outages while maintaining data integrity and user interface functionality.

Confidence score: 4/5

• This PR is generally safe to merge with only minor considerations around fallback data handling
• Score reflects solid error handling improvements with minimal risk, though the weather fallback logic could benefit from additional validation
• Pay closer attention to the hourly.sh changes to ensure the fallback weather data format is compatible with all downstream consumers

_{2 files reviewed, no comments}

_{Edit Code Review Bot Settings | Greptile}