fix(ref): root level refs to local schema doesn't try to resolve erronous paths anymore#211
Merged
dadav merged 4 commits intodadav:mainfrom Apr 14, 2026
Merged
Conversation
`/bin/bash` doesn't exist on all systems, like NixOS or other non FHS based setups `/usr/bin/env bash` does
test_ref_properties works, test_ref_toplevel doesn't (as reported in dadav#210)
handleSchemaRefs now recognizes that `#/...` refs don't reference other schemas, and IsRelativeFile stops claiming that empty strings are actually relative paths (if someone would still ask) handleSchemaRefs is the only caller of IsRelativeFile at the moment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full disclosure:
Thank you for your test coverage, and your CLAUDE.md for making me hand this over to Copilot.
It also motivated me a bit to see that I still had this repo forked - happy to be able to open a Pull Request for this project again!
I think I made my first baby steps with go for helm-schema back around version 0.12.0, a while ago :)
Fixes #210