Include FlatExpression.cs in src nuget packages and Internal build script#528
Merged
Include FlatExpression.cs in src nuget packages and Internal build script#528
Conversation
Agent-Logs-Url: https://github.com/dadhi/FastExpressionCompiler/sessions/080c65a7-3c64-4219-b704-10478eda399a Co-authored-by: dadhi <39516+dadhi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on LightExpression model and testing improvements
Include FlatExpression.cs in src nuget packages and Internal build script
Apr 21, 2026
Base automatically changed from
copilot/optimize-expression-representation
to
master
April 21, 2026 20:57
dadhi
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FlatExpression.cswas missing from the src nuspec packages and theMakeInternal.ps1build script, meaning it would be absent from distributed source packages and the Internal package variant.Changes
nuspecs/FastExpressionCompiler.LightExpression.src.nuspec— AddedFlatExpression.csfile entries fornet472,netstandard2.0, andnet8.0content targets, matching the pattern used forExpression.csandExpressionVisitor.cs.nuspecs/FastExpressionCompiler.LightExpression.Internal.src.nuspec— Same additions, referencing the generatedFastExpressionCompiler.Internal/path.BuildScripts/MakeInternal.ps1— AddedFlatExpression.csto the input file list so the script generates an internalized copy alongside the other LightExpression sources.FlatExpression tests are already exercised in both the
.netand.net472test runners via the existingLightExpressionTests().Runcall.