Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upMedia collection enhancements #431
Conversation
jimlambie
added some commits
Jun 1, 2018
jimlambie
requested a review
from
eduardoboucas
Jun 3, 2018
jimlambie
added
status: needs docs
product: API
labels
Jun 3, 2018
jimlambie
merged commit 3354b11
into
develop
Jun 6, 2018
jimlambie
deleted the
feature/media-enhancements
branch
Jun 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jimlambie commentedJun 3, 2018
DELETE
This PR adds the ability to send a DELETE request to a media collection, specifying a media document's _id property in the URL.
If successful, a 200 response is returned (or a 204 if
feedback: false
in config):GET
This PR also adds support for GET requests for specific media files, e.g. http://localhost:3001/media/2018/06/02/norway.jpg
Digital Ocean Spaces
This PR also extends the S3 storage handler to support Digital Ocean Spaces. Simply add a DO access key + secret and an
endpoint
to configuration.