Fixes to image manipulation parameters#369
Merged
eduardoboucas merged 5 commits intodevelopfrom Jun 4, 2018
Merged
Conversation
Contributor
Author
|
@jimlambie Updated URLs in the README. Happy for it to be released as 3.0.1? |
Contributor
|
@eduardoboucas LGTM 🎈 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's included:
When
widthandheightare supplied, the current default resize style isentropy. The reason being that, if the image will be cropped, we're better off supplying a meaningful crop when no other parameters are supplied. However, whengravityis supplied, that should take precedence over the entropy-based crop. For this reason,aspectfillbecomes the default resize style whenwidth,heightandgravityare supplied.A fix for a regression introduced in version 2.0 that ignored the
dprparameter unless the resize style was set tocrop. The parameter is now taken into account regardless of the resize style being used.A
npmignorefile removing dev-only assets, like thetestdirectory which weighs ~20MB, from the published module.Visual regression tests for points 1. and 2. are included.
/cc @fra967