Upload samples to tracks in the active pattern (Digitakt only)#205
Merged
Conversation
This seems like a very old bug that happens when trying to download factory samples. The bug was caused by a bad check over the result of the open-for-reading operation. This was affecting downloading samples from RAM too as the sample is actually downloaded from the +Drive using the `sample` filesystem.
Empty slots were not detected as such and thus returning a ENOMEM. The issue was introduced in 2eb3265 because the way to detect empty slots changed. Now, an empty slot is reported as having a size of -1, which not only is the standard way but it also indicates that the size empty in the GUI and CLI.
All the operations included here * should not provide any synchronization method to access the sample and * must support data in both s16 and f32 formats.
It works as the track filesystem but, if the sample has the tempo set, it will timestretch it to match the current pattern tempo.
Tempo can be set at pattern or globally. Both values are retrieved.
dagargo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The work on this feature has been commented in #136.