Skip to content

fix: use alt interface with higher max packet size#35

Merged
dagargo merged 1 commit intodagargo:j2o_always_onfrom
serratedserenade:fix/usb-interface-alt-setting
Jun 10, 2022
Merged

fix: use alt interface with higher max packet size#35
dagargo merged 1 commit intodagargo:j2o_always_onfrom
serratedserenade:fix/usb-interface-alt-setting

Conversation

@serratedserenade
Copy link
Contributor

@serratedserenade serratedserenade commented Jun 10, 2022

I think based on the lsusb outputs for our devices, I think 2 is possibly the class compliant one, and 3 is the Overbridge variant? A guess at best. Considering it seems to be present on 4 of the modern devices we have tested (DT, ST, AHmk2, A4mk2), it should be safe to assume it'd be the same on the others.

@serratedserenade serratedserenade force-pushed the fix/usb-interface-alt-setting branch from df908e3 to 5201ab3 Compare June 10, 2022 13:06
@dagargo dagargo merged commit 1d6802a into dagargo:j2o_always_on Jun 10, 2022
@dagargo
Copy link
Owner

dagargo commented Jun 10, 2022

This works with my Digitakt so, although we don't know for sure about the Digitone, it's very likely that it will too as the architecture of both machines is pretty similar.

If not, we'll need to add the alt interface to the device definitions.

@serratedserenade
Copy link
Contributor Author

serratedserenade commented Jun 10, 2022

@dagargo I also have a DN and it's present. Though surprisingly this is the one case where it looks exactly the same
lsusb.digitone.txt

    Interface Descriptor:
      bLength                 9
      bDescriptorType         4
      bInterfaceNumber        2
      bAlternateSetting       2
      bNumEndpoints           1
      bInterfaceClass       255 Vendor Specific Class
      bInterfaceSubClass      0 
      bInterfaceProtocol      0 
      iInterface              0 
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x03  EP 3 OUT
        bmAttributes            3
          Transfer Type            Interrupt
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0058  1x 88 bytes
        bInterval               1
    Interface Descriptor:
      bLength                 9
      bDescriptorType         4
      bInterfaceNumber        2
      bAlternateSetting       3
      bNumEndpoints           1
      bInterfaceClass       255 Vendor Specific Class
      bInterfaceSubClass      0 
      bInterfaceProtocol      0 
      iInterface              0 
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x03  EP 3 OUT
        bmAttributes            3
          Transfer Type            Interrupt
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0058  1x 88 bytes
        bInterval               1

I just remembered I wanted to ask why I couldn't manipulate input audio with DN effects but I guess its built this way.

Only ones left to confirm now are AR and DN Keys.

@serratedserenade serratedserenade deleted the fix/usb-interface-alt-setting branch June 10, 2022 13:56
@dagargo
Copy link
Owner

dagargo commented Jun 10, 2022

It's exactly like this with my Digitakt too and I think it's by design. But we can ask on Elektronauts.

Overwitch audio outputs go directly to the main physical output, so it is mixed with the device output. These do not even go to the Overbridge output!

But I guess it make sense. After all, we could disconnect all the tracks from the main output so only the Overwitch audio outputs will go directly to the physical output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants