This repository was archived by the owner on Oct 4, 2022. It is now read-only.
Format paths for Linux platform containers#192
Closed
cdhunt wants to merge 1 commit into
Closed
Conversation
👷 Deploy request for cloak-docs pending review.A Netlify team Owner will need to approve the deploy before you can run your build. Are you a team Owner? Visit the deploys page to approve it → Need more help? Learn more in the Netlify docs →
|
Signed-off-by: Chris Hunt <chunt@stackoverflow.com>
Contributor
|
does this still works in unix? |
Contributor
Author
|
It works for me in Ubuntu in WSL. |
marcosnils
approved these changes
Sep 9, 2022
Contributor
|
Hey @cdhunt we are working on migrating PRs to a different repo and wanted to make that as easy as possible for you, so I went ahead and rebased this and merged in a different PR: #228 Appreciate the contribution! There is a follow up described here but I was not even aware of this issue before your change, so it's extremely helpful to have the initial one in and to know that we have to deal with this going forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't a permanent solution. If
cloakever wants to support Windows containers, I'm not sure this will work. But, it gets me past the extension install phase so I can actually test other parts.