Terraform extension#211
Conversation
Signed-off-by: kpenfound <kyle@dagger.io>
Signed-off-by: kpenfound <kyle@dagger.io>
Signed-off-by: kpenfound <kyle@dagger.io>
Signed-off-by: kpenfound <kyle@dagger.io>
Signed-off-by: kpenfound <kyle@dagger.io>
Signed-off-by: kpenfound <kyle@dagger.io>
Signed-off-by: kpenfound <kyle@dagger.io>
Signed-off-by: kpenfound <kyle@dagger.io>
✅ Deploy Preview for cloak-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Signed-off-by: kpenfound <kyle@dagger.io>
Signed-off-by: kpenfound <kyle@dagger.io>
Signed-off-by: kpenfound <kyle@dagger.io>
Signed-off-by: kpenfound <kyle@dagger.io>
|
Working example here: https://github.com/kpenfound/cloak-ruby/blob/main/script/tfplan.mjs |
There was a problem hiding this comment.
This looks awesome!
On the content of the extension itself, my only comment is: I can't wait to see a demo and try it :)
Since you're the first contributed extension, the rest of my feedback applies to all future extensions as well:
Let's keep this in an external repo. It doesn't matter where exactly. Non-official (ie in your personal repo @kpenfound) is better. This may seem unintuitive but it has several benefits:
-
It bootstraps the process of sharing and reusing code in the community, which is crucial. Merging into the core repo doesn't scale to the entire community, but publishing a repo somewhere and sharing information on how to reuse it, does. So we should do what the rest of the community can do too.
-
It sets lower expectations in terms of future breakage, stability, quality etc. This will remove pressure from our shoulders. If the extension breaks from a guy called Kyle, that has different implications than if Dagger's official core extension breaks. This gives us breathing room and allows us to move faster.
-
We can defer difficult conversations about namespacing, contribution workflows, maintenance responsibility etc.
In terms of this PR, my request is:
- Move the extension code itself to a location of your choice in the repo of your choice, on your personal accounbt
- Change this PR to document the existence of the extension, and how to use it.
Thanks!
|
Thanks @shykes , that makes sense for the future of Something like:
|
|
No opinion on convention, do what feels right for you and we'll figure it out together :) |
|
Extension now available here: https://github.com/kpenfound/dagger-terraform I'll create a new PR to make a reference to it somewhere in cloak! |
This is a Terraform extension.
The initial version is built with Terraform Cloud support in mind, as it's the easiest way to manage secrets for terraform runs. To support other forms of remote state, we'd probably want the ability to input arbitrary
SecretEnvor write a temporaryterraform.auto.tfvarsin a previous step and maybe provide a utility to do that.Example usage: