feat: add context directory module#4
Conversation
Signed-off-by: Vasek - Tom C <tom.chauveau@epitech.eu>
jedevc
left a comment
jedevc
left a comment
There was a problem hiding this comment.
LGTM, cc @grouville - can we also mirror these changes when merged to the other repos we have?
| func (m *Test) AbsolutePath( | ||
| // +defaultPath="/" | ||
| dir *dagger.Directory, | ||
| ) *dagger.Directory { | ||
| return dir | ||
| } | ||
|
|
||
| func (m *Test) RelativePath( | ||
| // +defaultPath="." | ||
| dir *dagger.Directory, | ||
| ) *dagger.Directory { | ||
| return dir | ||
| } |
There was a problem hiding this comment.
Can we also get some sub-paths? Something like /data and ./data, so we can check the differences between those as well?
There was a problem hiding this comment.
I mean, / will point to the root of the repo while . will point to the current dir so we can already do some further queries in our test to get a specific dir
like dagger call absolute-path directory --path "context-dir" & dagger call relative-path directory --path "src"
There was a problem hiding this comment.
So should I still add new method?
There was a problem hiding this comment.
I think it would be good to have a couple of new methods, and put some content there, just so we can check that the path joining logic is all correct in the tests.
Signed-off-by: Vasek - Tom C <tom.chauveau@epitech.eu>
|
@jedevc Still waiting for your approval on that one :D |
2 participants
No description provided.