Realized as I was chatting about something that the serving of a nested session needs to occur inside the shim() func, whereas today it's in the setupBundle() func: https://github.com/sipsma/dagger/blob/6272f1919c78abb46c83fe5e1e460a71ef7a9980/cmd/shim/main.go#L207-L207
Otherwise, the local dirs referenced by the nested session will be incorrect and outside the container.
The fix is simple but going to add some explicit tests for this. It got missed because previously our test coverage of nested sessions happened implicitly by using dagger-in-dagger to run all our CI tests, but since we moved away from that it's not covered anymore
Realized as I was chatting about something that the serving of a nested session needs to occur inside the
shim()func, whereas today it's in thesetupBundle()func: https://github.com/sipsma/dagger/blob/6272f1919c78abb46c83fe5e1e460a71ef7a9980/cmd/shim/main.go#L207-L207Otherwise, the local dirs referenced by the nested session will be incorrect and outside the container.
The fix is simple but going to add some explicit tests for this. It got missed because previously our test coverage of nested sessions happened implicitly by using dagger-in-dagger to run all our CI tests, but since we moved away from that it's not covered anymore