`WithDefaultTerminalCommand` doesn't support privileged or nesting

[shykes]

Problem

Container.WithDefaultTerminalCommand allows configuring the command to be executed by Container.Terminal. But some execution options are not available:

Option	Description	Available in withExec	Available in withDefaultTerminalCmd
experimentalPrivilegedNesting	Allow the executed command to make API calls to the Dagger Engine running it	✅	❌
insecureRootCapabilities	Execute the command in a privileged linux container	✅	❌

Solution

Add the missing arguments to Container.withDefaultTerminalCmd.

[TomChv]

I've been working on that one!

This requires updates in Terminal too and makes some arguments optionals.
Here's the new struct I generated!

// ContainerTerminalOpts contains options for Container.Terminal
type ContainerTerminalOpts struct {
	// If set, override the container's default terminal command and invoke these command arguments instead.
	Cmd []string
	// Provides dagger access to the executed command.
	//
	// Do not use this option unless you trust the command being executed; the command being executed WILL BE GRANTED FULL ACCESS TO YOUR HOST FILESYSTEM.
	ExperimentalPrivilegedNesting bool
	// Execute the command with all root capabilities. This is similar to running a command with "sudo" or executing "docker run" with the "--privileged" flag. Containerization does not provide any security guarantees when using this option. It should only be used when absolutely necessary and only with trusted commands.
	InsecureRootCapabilities bool
}

// Return an interactive terminal for this container using its configured default terminal command if not overridden by args (or sh as a fallback default).
func (r *Container) Terminal(opts ...ContainerTerminalOpts) *Terminal {...}


// ContainerWithDefaultTerminalCmdOpts contains options for Container.WithDefaultTerminalCmd
type ContainerWithDefaultTerminalCmdOpts struct {
	// Provides dagger access to the executed command.
	//
	// Do not use this option unless you trust the command being executed; the command being executed WILL BE GRANTED FULL ACCESS TO YOUR HOST FILESYSTEM.
	ExperimentalPrivilegedNesting bool
	// Execute the command with all root capabilities. This is similar to running a command with "sudo" or executing "docker run" with the "--privileged" flag. Containerization does not provide any security guarantees when using this option. It should only be used when absolutely necessary and only with trusted commands.
	InsecureRootCapabilities bool
}

// Set the default command to invoke for the container's terminal API.
func (r *Container) WithDefaultTerminalCmd(args []string, opts ...ContainerWithDefaultTerminalCmdOpts) *Container {...}

I'm going to add some tests on it too

[shykes]

Nice, thank you!