🐞 Dagger Fails to Honor GOPROXY Environment Variable

[crrow]

What is the issue?

Dagger is not correctly recognizing or using the GOPROXY environment variable to configure the cmd environment when executing go cmd.

Dagger version

dagger v0.15.1 (registry.dagger.io/engine:v0.15.1) darwin/arm64

Steps to reproduce

No response

Log output

[gtshepard]

Any plans to support GOPROXY? even if it's in this style via dagger.json config

Currently quite cumbersome to get a dagger module to pull private golang package when it's installed as a dependency in a dagger go project

Ideally would like to do anonymous pulls from an internal private registry url I set in GOPROXY.

If must use GOPRIVATE it means only option is authenticating via ssh. This has led to more complicated local development experience and infra setup (infra to use dagger in Github Actions workflows).

Essentially have to setup ssh agent forwarding for dagger engine.

Locally (mac)

eval "$(ssh-agent -s)"

SSH_AUTH_SOCK=`launchctl getenv SSH_AUTH_SOCK` ssh-add

docker run --rm \
  --mount type=bind,src=/run/host-services/ssh-auth.sock,target=/run/host-services/ssh-auth.sock \
  -e SSH_AUTH_SOCK=/run/host-services/ssh-auth.sock \
  -v /var/lib/dagger \
  -v ./engine.json:/etc/dagger/engine.json \
  --name dagger-engine-custom-5555 \
  --privileged \
  registry.dagger.io/engine:v0.18.16

in separate shell

export _EXPERIMENTAL_DAGGER_RUNNER_HOST=docker-container://dagger-engine-custom-5555

then call the dagger func that relies on the go private package

dagger --progress=plain call \
       greet \
       --name jim

GHA Workflows

Deploying dagger helm chart for engine requires similar idea with ssh agent side car.

Adds complexity to the k8s deployment and adds additional operational overhead managing a key/account

[gtshepard]

After digging deeper found GOPROXY can be set #6599

For the dagger engine that you spin up and and connect to, the this environment var

_DAGGER_ENGINE_SYSTEMENV_GOPROXY=<yourprivateregistry>,<backupregistry>

Locally

docker run --rm \
  -e _DAGGER_ENGINE_SYSTEMENV_GOPROXY=<yourprivateregistry>,<backupregistry>,direct \
  -v /var/lib/dagger \
  -v ./engine.json:/etc/dagger/engine.json \
  --name dagger-engine-custom-5555 \
  --privileged \
  registry.dagger.io/engine:v0.18.9

client side shell

export _EXPERIMENTAL_DAGGER_RUNNER_HOST=docker-container://dagger-engine-custom-5555

dagger --progress=plain call greet --name jim

Helm Chart

in your values.yml file

fullnameOverride: <mydaggerenginename>
engine:
env:
  - name: _DAGGER_ENGINE_SYSTEMENV_GOPROXY
    value: <yourprivateregistry>,<backupregistry>,direct

[jedevc]

Oops, this should be more plainly documented 😢

Thanks for flagging @gtshepard, sorry it sent you down a rabbit hole - feel free to ask in discord/etc next time as well, sometimes our docs don't mention some of these edge cases as much as they should!

[gtshepard]

Oh nice, thanks @jedevc, will join!