fix: handle empty argument case in shell completion#10124
Closed
kasattejaswi wants to merge 5 commits into
Closed
Conversation
Signed-off-by: Tejaswi Kasat<kasattejasvi@gmail.com>
Signed-off-by: Vikram Vaswani <vikram@dagger.io>
* docs: add documentation for private Go module support Signed-off-by: Vikram Vaswani <vikram@dagger.io> * Update code snippet Signed-off-by: Vikram Vaswani <vikram@dagger.io> * Updated text Signed-off-by: Vikram Vaswani <vikram@dagger.io> * Updated example Signed-off-by: Vikram Vaswani <vikram@dagger.io> * Added feedback Signed-off-by: Vikram Vaswani <vikram@dagger.io> * Updated code snippet Signed-off-by: Vikram Vaswani <vikram@dagger.io> * Updated text Signed-off-by: Vikram Vaswani <vikram@dagger.io> * Added feedback Signed-off-by: Vikram Vaswani <vikram@dagger.io> * Added feedback Signed-off-by: Vikram Vaswani <vikram@dagger.io> --------- Signed-off-by: Vikram Vaswani <vikram@dagger.io>
* add example on github actions integration page to use dagger shell Signed-off-by: kpenfound <kyle@dagger.io> * add depot example too Signed-off-by: kpenfound <kyle@dagger.io> --------- Signed-off-by: kpenfound <kyle@dagger.io>
* docs: Move content-related images and remove unused images Signed-off-by: Vikram Vaswani <vikram@dagger.io> * Fixed file paths Signed-off-by: Vikram Vaswani <vikram@dagger.io> --------- Signed-off-by: Vikram Vaswani <vikram@dagger.io> Co-authored-by: Jeremy Adams <jeremy@dagger.io>
Contributor
|
👋 hey @kasattejaswi was there a reason you closed this? it looks like the PR did have some wrong commits in it, but you should be able to Just as a note for the future! |
Contributor
Author
|
Hey @jedevc I actually messed up with the signing thing. I read that documentation after committing the code. So I thought, it would be cleaner to do things again. Will keep in mind in future. |
Contributor
|
For signing, you can actually just do Generally, it's fine to do lots of rewriting git history in a PR, as long as the final diff + commits look relatively clean! 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first PR, please let me know if I am missing something.
This PR addresses bug where the shell was crashing due to a slice bounds out of range [1:0] error in
dispatchCall, caused by accessingargs[0]whencall.Argsis empty.