ci: Migrate the remaining jobs to an alternative CI runner#10503
Merged
gerhard merged 2 commits intoJun 2, 2025
Merged
Conversation
jedevc
approved these changes
May 30, 2025
| {"call-and-shell", []string{"TestCall", "TestShell", "TestDaggerCMD"}, &dagger.GhaJobOpts{ | ||
| Runner: AltGoldRunner(), | ||
| }}, | ||
| {"container", []string{"TestContainer"}, &dagger.GhaJobOpts{}}, |
Contributor
There was a problem hiding this comment.
nit: we should allow this to be nil, and handle that in splitTests.
Contributor
Author
There was a problem hiding this comment.
I tried this, and the explicit &dagger.GhaJobOpts{} felt more honest & easier to follow for me.
It also made it easier to know what type that nil was keeping the place of. Adding extra properties was also easier - the type was already there.
Adding the diff here for completeness, but the current implementation feels right to me:
diff --git a/.github/main.go b/.github/main.go
index f0e320861..7d6a9a908 100644
--- a/.github/main.go
+++ b/.github/main.go
@@ -197,19 +197,19 @@ func (ci *CI) withTestWorkflows(runner *dagger.Gha, name string) *CI {
Runner: AltBronzeRunnerWithCache(),
})).
With(splitTests(runner, "testdev-", true, []testSplit{
- {"cgroupsv2", []string{"TestProvision", "TestTelemetry"}, &dagger.GhaJobOpts{}},
+ {"cgroupsv2", []string{"TestProvision", "TestTelemetry"}, nil},
{"modules", []string{"TestModule"}, &dagger.GhaJobOpts{
Runner: AltPlatinumRunner(),
}},
{"module-runtimes", []string{"TestGo", "TestPython", "TestTypescript", "TestElixir", "TestPHP", "TestJava"}, &dagger.GhaJobOpts{
Runner: AltPlatinumRunner(),
}},
- {"container", []string{"TestContainer"}, &dagger.GhaJobOpts{}},
- {"LLM", []string{"TestLLM"}, &dagger.GhaJobOpts{}},
- {"cli-engine", []string{"TestCLI", "TestEngine"}, &dagger.GhaJobOpts{}},
- {"client-generator", []string{"TestClientGenerator"}, &dagger.GhaJobOpts{}},
- {"interface", []string{"TestInterface"}, &dagger.GhaJobOpts{}},
- {"call-and-shell", []string{"TestCall", "TestShell", "TestDaggerCMD"}, &dagger.GhaJobOpts{}},
+ {"container", []string{"TestContainer"}, nil},
+ {"LLM", []string{"TestLLM"}, nil},
+ {"cli-engine", []string{"TestCLI", "TestEngine"}, nil},
+ {"client-generator", []string{"TestClientGenerator"}, nil},
+ {"interface", []string{"TestInterface"}, nil},
+ {"call-and-shell", []string{"TestCall", "TestShell", "TestDaggerCMD"}, nil},
{"everything-else", nil, &dagger.GhaJobOpts{
Runner: AltPlatinumRunner(),
}},
@@ -239,12 +239,16 @@ func splitTests(runner *dagger.Gha, name string, dev bool, splits []testSplit) d
}
doneTests = append(doneTests, split.tests...)
- opts := *split.opts
+ opts := dagger.GhaJobOpts{}
+ if split.opts != nil {
+ opts = *split.opts
+ }
opts.TimeoutMinutes = 30
opts.UploadLogs = true
if dev {
opts.DaggerVersion = "."
}
+
w = w.WithJob(runner.Job(name+split.name, command, opts))
}
return w
added 2 commits
June 2, 2025 19:39
We have been hitting networking issues in AWS, this should address them and also speed things up. Let's check this before merging. Also, use the platform cache across the SDK jobs since it seems to speed **each** job up by a good few minutes. Signed-off-by: Gerhard Lazu <gerhard@dagger.io>
- let it pick which db source to use - resolve deprecated vuln-type Signed-off-by: Gerhard Lazu <gerhard@dagger.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have been hitting networking issues in AWS, this should address them and also speed things up.
Also, use the platform cache across the SDK jobs since it seems to speed each job up by a good few minutes.