idtui: fix data race in TestTelemetry#10528
Merged
Merged
Conversation
This is just the minimum viable change to fix the data race on `main`. We currently lock in the _user_ of the `dagui.DB` instead of in the `dagui.DB` itself; in practice this race doesn't occur since it's guarded by the mutex in the `Frontend`. It could be worth considering pushing this down into the `DB` but I've been here before and previously decided it's better to let the `DB` consume things as fast as possible and trust the caller to synchronize more coarsely. So, this change just continues the status quo and adds a lock to the OTLP receiver in the tests. Signed-off-by: Alex Suraci <alex@dagger.io>
jedevc
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just the minimum viable change to fix the data race on
main.We currently lock in the user of the
dagui.DBinstead of in thedagui.DBitself; in practice this race doesn't occur since it's guarded by the mutex in theFrontend.It could be worth considering pushing this down into the
DBbut I've been here before and previously decided it's better to let theDBconsume things as fast as possible and trust the caller to synchronize more coarsely.So, this change just continues the status quo and adds a lock to the OTLP receiver in the tests.