Improve version checking to also check universe#1085
Merged
Conversation
In the future, universe will not be embedded anymore in dagger, instead, it will be remotely vendor from `dagger/universe` repository. To make sure that users always use the latest universe version, the version checking now also verify that universe is not outdated. If universe needs an update, a message is printed to standard output. Signed-off-by: Tom Chauveau <tom.chauveau@epitech.eu>
Signed-off-by: Tom Chauveau <tom.chauveau@epitech.eu>
Dagger now compare the remote universe version with the one written in dagger.mod. I've also added logs to easily debug code Signed-off-by: Tom Chauveau <tom.chauveau@epitech.eu>
Signed-off-by: Tom Chauveau <tom.chauveau@epitech.eu>
|
✔️ Deploy Preview for devel-docs-dagger-io ready! 🔨 Explore the source changes: c808f4e 🔍 Inspect the deploy log: https://app.netlify.com/sites/devel-docs-dagger-io/deploys/617c30bc0a9d230008deb97f 😎 Browse the preview: https://deploy-preview-1085--devel-docs-dagger-io.netlify.app |
Signed-off-by: Tom Chauveau <tom.chauveau@epitech.eu>
Signed-off-by: Tom Chauveau <tom.chauveau@epitech.eu>
Contributor
|
@TomChv is it still WIP? |
samalba
approved these changes
Nov 4, 2021
TomChv
changed the title
Member
Author
|
@samalba No it's good 👍 , I forgot to update PR's name |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
checkVersionto also check universe.Changes
In the future, universe will not be embedded anymore in dagger,
instead, it will be remotely vendor from
dagger/universerepository.To make sure that users always use the latest universe version, the
version checking now also verifies that universe is not outdated.
If universe needs an update, a message is printed to standard output.