core: handle nil returns in various places#11420
Merged
Merged
Conversation
A user reported a panic from ContainerDagOp where it was hitting either a nil return from LoadType or a return that when unwrapped is nil. I don't have a repro for that yet, so the code there is just an update to turn that into an error and include more debug information to help track it down if/when it happens again. However while attempting repros of it I managed to hit independent panics involving modules returning various permutations of nil things in lists. Fixed those here and included integ test coverage. Signed-off-by: Erik Sipsma <erik@sipsma.dev>
marcosnils
approved these changes
Nov 15, 2025
raykao
pushed a commit
to raykao/dagger
that referenced
this pull request
Dec 9, 2025
A user reported a panic from ContainerDagOp where it was hitting either a nil return from LoadType or a return that when unwrapped is nil. I don't have a repro for that yet, so the code there is just an update to turn that into an error and include more debug information to help track it down if/when it happens again. However while attempting repros of it I managed to hit independent panics involving modules returning various permutations of nil things in lists. Fixed those here and included integ test coverage. Signed-off-by: Erik Sipsma <erik@sipsma.dev>
raykao
pushed a commit
to raykao/dagger
that referenced
this pull request
Dec 14, 2025
A user reported a panic from ContainerDagOp where it was hitting either a nil return from LoadType or a return that when unwrapped is nil. I don't have a repro for that yet, so the code there is just an update to turn that into an error and include more debug information to help track it down if/when it happens again. However while attempting repros of it I managed to hit independent panics involving modules returning various permutations of nil things in lists. Fixed those here and included integ test coverage. Signed-off-by: Erik Sipsma <erik@sipsma.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A user reported a panic from ContainerDagOp where it was hitting either a nil return from LoadType or a return that when unwrapped is nil.
I don't have a repro for that yet, so the code there is just an update to turn that into an error and include more debug information to help track it down if/when it happens again.
However while attempting repros of it I managed to hit independent panics involving modules returning various permutations of nil things in lists. Fixed those here and included integ test coverage.