fix: generate sdk typescript if node_modules#11927
Merged
eunomie merged 1 commit intodagger:mainfrom Mar 2, 2026
Merged
Conversation
In case node_modules directory is present, the generate function
might fail with an error like:
get patch: file size 134250496 exceeds limit 134217728
Ignoring the directory is enough to fix the issue.
Signed-off-by: Yves Brissaud <yves@dagger.io>
tiborvass
approved these changes
Feb 27, 2026
Contributor
|
@grouville it's possible you were hitting this too yesterday |
Member
@tiborvass Possible, but I don't think so, as I didn't touch the typescript SDK at all ... I've started a side PR that streams the changesets (and its preview) instead of loading it in-memory |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case node_modules directory is present, the generate function might fail with an error like:
Ignoring the directory is enough to fix the issue.