Europa: engine.#Mkdir#1259
Merged
Merged
Conversation
|
✔️ Deploy Preview for devel-docs-dagger-io ready! 🔨 Explore the source changes: 3447cf756650f1f3a21d73b2d168d42873e3b9c8 🔍 Inspect the deploy log: https://app.netlify.com/sites/devel-docs-dagger-io/deploys/61c11d2cf2afca0007cd4b06 😎 Browse the preview: https://deploy-preview-1259--devel-docs-dagger-io.netlify.app |
shykes
reviewed
Dec 18, 2021
Signed-off-by: Vasek - Tom C <tom.chauveau@epitech.eu>
Signed-off-by: Vasek - Tom C <tom.chauveau@epitech.eu>
Signed-off-by: Vasek - Tom C <tom.chauveau@epitech.eu>
aluzzardi
reviewed
Dec 21, 2021
Contributor
aluzzardi
left a comment
aluzzardi
left a comment
There was a problem hiding this comment.
Looks good, minor comments
Contributor
There was a problem hiding this comment.
nit: should be outputFS (Go convention for acronyms, e.g. myIP, userID, outputFS, ...)
Contributor
There was a problem hiding this comment.
all Mkdir tests can be just in this one @test
Closed
Signed-off-by: Vasek - Tom C <tom.chauveau@epitech.eu>
aluzzardi
approved these changes
Dec 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
#Mkdirfrom spec to active definition