sdk(dang): implement @up annotation#12919
Merged
eunomie merged 3 commits intodagger:mainfrom Apr 8, 2026
Merged
Conversation
vito
approved these changes
Apr 7, 2026
Contributor
vito
left a comment
vito
left a comment
There was a problem hiding this comment.
nice! just some style nitpicks
tiborvass
approved these changes
Apr 7, 2026
Add support for the @up directive in the Dang SDK, matching the existing +up (Go), @up() (TypeScript), @up (Python), and @up (Java) annotations. - Declare @up in the coreDirectives schema (dagql/server.go) so the Dang parser accepts it - Handle case "up" in the directive switch in dang_op.go to emit the withUp dagql selector during module registration - Add hello-with-services-dang test fixture with web, redis, and nested infra:database services - Add Dang to TestUpDirectSDK and TestUpAsToolchain integration tests Signed-off-by: Yves Brissaud <yves@dagger.io>
Co-authored-by: Alex Suraci <suraci.alex@gmail.com> Signed-off-by: Yves Brissaud <yves.brissaud@gmail.com>
Signed-off-by: Tibor Vass <teabee89@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the @up directive in the Dang SDK, matching the existing +up (Go), @up() (TypeScript), @up (Python), and @up (Java) annotations.