Bump up sass package to 1.46.0#1376
Conversation
|
✔️ Deploy Preview for devel-docs-dagger-io ready! 🔨 Explore the source changes: 6952a92 🔍 Inspect the deploy log: https://app.netlify.com/sites/devel-docs-dagger-io/deploys/61dd40c214e55d0007c60bb9 😎 Browse the preview: https://deploy-preview-1376--devel-docs-dagger-io.netlify.app |
Signed-off-by: jffarge <jf@dagger.io>
|
This looks good to me, merging. While some of the checks on the main branch are failing, this change is completely unrelated to those failing checks. Going forward, I would like us to consider the following:
|
|
@gerhard : we actually already use dependabot. I've created this new branch because the one with dependabot had more check fails even after a rebase. |
That is great! Are you saying that there are Dependabot-related issues? |
Still the same issues with CI. Here is an example of dependabot branch with failure : #1383 event after a rebase |
|
Those failures are not related to node modules getting updated. I am still trying to understand the source of these failures. Some are happening due to missing secrets, which I think is expected for forks. I don't have a complete mental model of our test suite, but I am slowly build it up. I need to put a pin in this for now. I intend to come back to this after I have dealt with the other priorities. |
|
Ok thanks ! @samalba is already aware of those failures. |
|
@grouville put in a place a temporary quick fix that gets the main branch green again: #1386 |

Signed-off-by: jffarge jf@dagger.io