Skip to content

Bump up sass package to 1.46.0#1376

Merged
gerhard merged 1 commit into
dagger:mainfrom
slumbering:bump-up-sass-1.46
Jan 11, 2022
Merged

Bump up sass package to 1.46.0#1376
gerhard merged 1 commit into
dagger:mainfrom
slumbering:bump-up-sass-1.46

Conversation

@slumbering
Copy link
Copy Markdown
Contributor

Signed-off-by: jffarge jf@dagger.io

@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 10, 2022

✔️ Deploy Preview for devel-docs-dagger-io ready!

🔨 Explore the source changes: 6952a92

🔍 Inspect the deploy log: https://app.netlify.com/sites/devel-docs-dagger-io/deploys/61dd40c214e55d0007c60bb9

😎 Browse the preview: https://deploy-preview-1376--devel-docs-dagger-io.netlify.app

Signed-off-by: jffarge <jf@dagger.io>
@gerhard
Copy link
Copy Markdown
Contributor

gerhard commented Jan 11, 2022

This looks good to me, merging.

While some of the checks on the main branch are failing, this change is completely unrelated to those failing checks.

Going forward, I would like us to consider the following:

@gerhard gerhard merged commit eeed798 into dagger:main Jan 11, 2022
@slumbering
Copy link
Copy Markdown
Contributor Author

@gerhard : we actually already use dependabot. I've created this new branch because the one with dependabot had more check fails even after a rebase.

@gerhard
Copy link
Copy Markdown
Contributor

gerhard commented Jan 11, 2022

@gerhard : we actually already use dependabot. I've created this new branch because the one with dependabot had more check fails even after a rebase.

That is great! Are you saying that there are Dependabot-related issues?

@gerhard
Copy link
Copy Markdown
Contributor

gerhard commented Jan 11, 2022

OK, I can see it now:
image

This PR upgrades sass from 1.43.5 to 1.46.0, while Dependabot wanted to upgrade to 1.47.0 in #1384. As soon as this PR was merged, #1384 was closed. Not sure what happened there... Maybe Dependabot is going to open another PR to upgrade from 1.46.0 to 1.47.0 🤷🏼‍♂️

@slumbering
Copy link
Copy Markdown
Contributor Author

slumbering commented Jan 11, 2022

@gerhard : we actually already use dependabot. I've created this new branch because the one with dependabot had more check fails even after a rebase.

That is great! Are you saying that there are Dependabot-related issues?

Still the same issues with CI. Here is an example of dependabot branch with failure : #1383 event after a rebase

@gerhard
Copy link
Copy Markdown
Contributor

gerhard commented Jan 11, 2022

Those failures are not related to node modules getting updated.

I am still trying to understand the source of these failures. Some are happening due to missing secrets, which I think is expected for forks. I don't have a complete mental model of our test suite, but I am slowly build it up.

I need to put a pin in this for now. I intend to come back to this after I have dealt with the other priorities.

@slumbering
Copy link
Copy Markdown
Contributor Author

Ok thanks ! @samalba is already aware of those failures.

@gerhard
Copy link
Copy Markdown
Contributor

gerhard commented Jan 11, 2022

@grouville put in a place a temporary quick fix that gets the main branch green again: #1386

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants