Skip to content

Add test on docker.#Run#1475

Merged
aluzzardi merged 1 commit into
dagger:mainfrom
TomChv:test/docker
Jan 25, 2022
Merged

Add test on docker.#Run#1475
aluzzardi merged 1 commit into
dagger:mainfrom
TomChv:test/docker

Conversation

@TomChv
Copy link
Copy Markdown
Member

@TomChv TomChv commented Jan 21, 2022

Changes

Related to #1407, add the following list of test on docker.#Run

  • Run a simple command
  • Run a script
  • Run a command from an image built
  • Export a file
  • Export a directory

@TomChv TomChv self-assigned this Jan 21, 2022
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this testing that verifyOutput is not?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It tests with another way and verify that the exported folder contains both files

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What error can verifyTest catch that verifyOutput cannot?

If the answer is none, this is a duplicate test which costs maintenance for no added benefit

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I understand, I'll fix it

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done on 4ab8523

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: No need to #ReadFile here

verify: "hello world" & run.export.files."/test/output.txt".contents

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was to be sure that we read the file and compare them

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if both #ReadFile and export fail in the same way (which they should, export uses #ReadFile underneath) then this test will pass ("" & "").

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I'll fix it!

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done on 4ab8523

Signed-off-by: Vasek - Tom C <tom.chauveau@epitech.eu>
@aluzzardi
Copy link
Copy Markdown
Contributor

Thank you @TomChv!

@aluzzardi aluzzardi merged commit 3c45dd1 into dagger:main Jan 25, 2022
@aluzzardi aluzzardi deleted the test/docker branch January 25, 2022 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants