Restore ssh (Universe) tests#1499
Merged
Merged
Conversation
This requires us to spin up a new dagger-ci VM, as mentioned here: #1493 (comment) Signed-off-by: Gerhard Lazu <gerhard@lazu.co.uk>
gerhard
changed the title
gerhard
changed the title
gerhard
changed the title
aluzzardi
reviewed
Jan 26, 2022
Contributor
aluzzardi
left a comment
aluzzardi
left a comment
There was a problem hiding this comment.
Looks good!
My only comment is to scope this in a sub-directory (e.g. infra or whatnot) since it's "internal" tooling, not relevant for most contributors
While at it, add help make target & make it the default.
This explains all make targets. Run `make help` to see it in action 😉
dagger-ci-pr1499-2022-01-26 API token was added as an AGE secret. It can
be accessed only by the intended recipients are able to decrypt it with
their private SSH keys.
echo "TOKEN" | age -R .age.recipients.txt -o .do.dagger-ci-pr1499-2022-01-26.age
Do not assume that /bin/true exists on hosts running Docker. Use "true"
and let the system resolve the path.
Re-enable all ssh Universe tests.
Signed-off-by: Gerhard Lazu <gerhard@lazu.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before we could restore the ssh (Universe) tests, we needed to spin up a new dagger-ci VM, see why: #1493 (comment)
Why did we go all declarative?
Since we don't have a Click Ops Officer on the team, and because we love declarative systems, we wanted to provision this VM in a declarative way. Any team member can now run a single command -
make dagger-ci- and some minutes later everything that we need for ssh (Universe) tests materializes.How did we do this?
With a bit of help from @tazjin, a NixOS guru. I was not expecting NixOS to fit this nicely in the Dagger Universe. I am so excited to explore what fitting Dagger within NixOS looks like 😉
What else is new & worth mentioning?
This will not work for all team members just yet:
