Fix tests cleanup logic#1641
Closed
dubo-dubon-duponey wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
Since I changed the tests, I would have expected the integration suite to run. |
aluzzardi
approved these changes
Feb 22, 2022
Contributor
|
Thank you @dubo-dubon-duponey! Our CI was badly broken over the last few days, it's back to green now :) Would you mind rebasing this PR so it's finally green? |
Signed-off-by: dubo-dubon-duponey <dubodubonduponey+github@pm.me>
dubo-dubon-duponey
force-pushed
the
fix1
branch
from
cc30d28 to
0bfb1bd
Compare
If the tests fail, generated files should still be removed to avoid leaving the tree in an unrecoverable condition. Signed-off-by: dubo-dubon-duponey <dubodubonduponey+github@pm.me>
Contributor
Author
|
@aluzzardi closing for now. I misdiagnosed the issue. I'll prepare another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Described first in #1640 : the cleanup logic does not seem right currently (generated files are not destroyed when asserts are failing, leading to situations where things are broken and the user has to go manually cleanup leftovers).
This make things more resilient, by unconditionally removing possible leftovers before (is there a better way to do that with bats? like a per-test teardown that would always execute?)
PTAL @aluzzardi