Replace HTTPS endpoint with npipe in #Socket description#1901
Merged
Conversation
✅ Deploy Preview for devel-docs-dagger-io ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This was mixing layer 4 & 7 concerns. It's clearer now. Signed-off-by: Gerhard Lazu <gerhard@lazu.co.uk>
gerhard
force-pushed
the
replace-https-with-npipe-comment-in-socket-type
branch
from
d8cba6d to
ad53d41
Compare
gerhard
changed the title
aluzzardi
approved these changes
Mar 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was mixing layer 4 & 7 concerns. It's clearer now.
Discovered via #1896