Skip to content

dagger do: log command args and target action #2560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcosnils merged 1 commit into from
Jun 2, 2022
Merged

dagger do: log command args and target action #2560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions cmd/dagger/cmd/do.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,12 @@ var doCmd = &cobra.Command{

targetPath := getTargetPath(cmd.Flags().Args())

lg.
Debug().
Str("targetAction", targetPath.String()).
Strs("args", os.Args[1:]).
Msg("running plan")

daggerPlan, err := loadPlan(ctx, viper.GetString("plan"))
if err != nil {
lg.Error().Err(err).Msgf("failed to load plan")
Expand Down Expand Up @@ -121,8 +127,6 @@ var doCmd = &cobra.Command{
os.Exit(1)
}

lg.Debug().Msgf("viper flags %#v", viper.AllSettings())

if err := viper.BindPFlags(cmd.Flags()); err != nil {
panic(err)
}
Expand Down
2 changes: 0 additions & 2 deletions plan/plan.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,6 @@ func Load(ctx context.Context, cfg Config) (*Plan, error) {
ctx, span := otel.Tracer("dagger").Start(ctx, "plan.Load")
defer span.End()

log.Ctx(ctx).Debug().Interface("args", cfg.Args).Msg("loading plan")

_, cueModExists := pkg.GetCueModParent()
if !cueModExists {
return nil, fmt.Errorf("dagger project not found. Run `dagger project init`")
Expand Down