docs: Provide more examples on client: commands and platform#2668
Conversation
Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com>
|
@helderco Love these improvements. Some users might be confused that they didn't get output for |
|
Yes, but non-output fields are private in these examples, so I don't see the confusion. |
samalba
left a comment
There was a problem hiding this comment.
Agreed with Helder, LGTM.
I have no issues with your examples :) If folks follow them, they will do well. 👍 I mean that I don't think there is anywhere in the docs where it is stated that the output fields must be generated fields. We should say that somewhere. Why not here? :) I can follow with a PR. I thought that since you'd been looking at these docs you might have best opinion on where to put that statement. |
|
I think the proper place for that is in https://docs.dagger.io/1228/handling-outputs |
Resolves #1890
👀 Preview
Signed-off-by: Helder Correia