Skip to content

chore: Update caniuse yarn dep#2884

Merged
grouville merged 1 commit into
dagger:mainfrom
gerhard:bump-caniuse-dep
Aug 3, 2022
Merged

chore: Update caniuse yarn dep#2884
grouville merged 1 commit into
dagger:mainfrom
gerhard:bump-caniuse-dep

Conversation

@gerhard
Copy link
Copy Markdown
Contributor

@gerhard gerhard commented Aug 2, 2022

Also add a yarn task that is able to update it automatically. I was getting warnings when running this locally before the update.

npx is required for browserlist --update-db to work.

Also add a yarn task that is able to update it automatically. I was
getting warnings when running this locally before the update.

npx is required for `browserlist --update-db` to work.

Signed-off-by: Gerhard Lazu <gerhard@lazu.co.uk>
@gerhard gerhard requested a review from crjm August 2, 2022 18:27
@gerhard gerhard requested a review from slumbering as a code owner August 2, 2022 18:27
Copy link
Copy Markdown
Contributor

@crjm crjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's OK to add npx as a dependency. I think we should look into moving the dev dependencies into the devDependencies field in the package.json in the future.

@grouville grouville merged commit d1de17d into dagger:main Aug 3, 2022
@gerhard gerhard deleted the bump-caniuse-dep branch August 3, 2022 10:20
@gerhard
Copy link
Copy Markdown
Contributor Author

gerhard commented Aug 3, 2022

It's OK to add npx as a dependency. I think we should look into moving the dev dependencies into the devDependencies field in the package.json in the future.

Great idea! If you submit a follow-up PR either today or tomorrow @crjm, I will be the first one to review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants