Guard against wrong dagger binary in Python SDK#3310
Merged
helderco merged 3 commits intoOct 12, 2022
Conversation
👷 Deploy request for cloak-docs pending review.Visit the deploys page to approve it
|
Contributor
Author
7 tasks
Contributor
|
Yes, looks like you're activating the environment on a subshell but then install and run on the global environment. I'll take a look at those instructions tomorrow. For now try moving the install and run inside those parenthesis. Don't forget to update paths accordingly because of the |
Contributor
|
Try this: python3 -m venv ../../.venv
source ../../venv/bin/activate
pip3 install -r requirements.txt
python3 query.py |
Contributor
|
We'll also need to add a |
Contributor
Author
|
All working, thanks @helderco! Please review & merge if it looks good to you.
|
Contributor
Author
samalba
approved these changes
Oct 12, 2022
helderco
approved these changes
Oct 12, 2022
Contributor
Yes I have that on my list but am prioritizing getting a codegen'ed client first. I'll create an issue. |
added 3 commits
October 12, 2022 12:07
Signed-off-by: Gerhard Lazu <gerhard@dagger.io>
This is meant to guard against running the "wrong" dagger. Versions prior to 0.3.x will not have commands that these SDKs depend on. Why exit 127 instead of 1? https://tldp.org/LDP/abs/html/exitcodes.html Signed-off-by: Gerhard Lazu <gerhard@dagger.io>
.venv (instead of venv) seems to be a Python convention. Signed-off-by: Gerhard Lazu <gerhard@dagger.io>
Contributor
Author
|
@helderco please merge if this looks good to you. |
This was referenced Oct 12, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to fail if the "wrong" dagger is used. Versions prior to 0.3.x will not have commands that these SDKs depend on.
Follow-up to #3285
Part of #3176