Skip to content

examples: alpine: use new Go SDK#3392

Merged
aluzzardi merged 1 commit into
dagger:mainfrom
aluzzardi:alpine-new-api
Oct 15, 2022
Merged

examples: alpine: use new Go SDK#3392
aluzzardi merged 1 commit into
dagger:mainfrom
aluzzardi:alpine-new-api

Conversation

@aluzzardi
Copy link
Copy Markdown
Contributor

  • Add support in extension API to directly return a codegen'd type
  • Convert alpine to the new SDK

Comment thread examples/alpine/main.go Outdated
@aluzzardi aluzzardi requested review from shykes, sipsma and vito October 14, 2022 22:44
Copy link
Copy Markdown
Contributor

@sipsma sipsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super awesome, glad the custom serialization is so easy to integrate here.

I feel like once (or if) we want to support this for types defined in other user extensions it's probably gonna be totally fine to just have the convention of ID being a special field. That seems well within reason I think.

@sipsma sipsma mentioned this pull request Oct 14, 2022
- Add support in extension API to directly return a codegen'd type
- Convert alpine to the new SDK

Signed-off-by: Andrea Luzzardi <aluzzardi@gmail.com>
@aluzzardi aluzzardi marked this pull request as ready for review October 15, 2022 00:35
@aluzzardi aluzzardi merged commit 5b1ad4d into dagger:main Oct 15, 2022
@aluzzardi aluzzardi deleted the alpine-new-api branch October 15, 2022 00:46
@shykes
Copy link
Copy Markdown
Contributor

shykes commented Oct 15, 2022

This is amazing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants