flatten ExecOpts into container.exec params#3402
Merged
Merged
Conversation
8d34f39 to
7835cd0
Compare
aluzzardi
approved these changes
Oct 17, 2022
Signed-off-by: Alex Suraci <alex@dagger.io>
7835cd0 to
78fe65c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3340
I ended up needing this because I need to be able to pass
Stdinbut that results in settingRedirectStdoutandRedirectStderrto an empty string because theExecOptsstruct wasn't a zero-value. Without this change I would get this from the shim:So this promotes these params to
execparams, removing the nesting, and removes the""vs.nildistinction for stdin, redirectStdout, and redirectStderr.I don't think there was any difference between
stdin: ""andstdin: nilbefore anyway; one would set it to an empty file, and the other would send it to/dev/null. From the process's perspective both would just yield EOF.I decided to keep a
ContainerExecOptstype around undercoresince it feels nicer than passingstring,string,string. 😄