Handle etxtbsy error in python sdk.#3905
Merged
Merged
Conversation
Signed-off-by: Erik Sipsma <erik@sipsma.dev>
Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com>
helderco
force-pushed
the
py-text-busy
branch
from
731108c to
1f4fda0
Compare
helderco
approved these changes
Nov 18, 2022
Contributor
helderco
left a comment
helderco
left a comment
There was a problem hiding this comment.
Error messages are not consistent with the following ones, but I can take care of that later.
Took 5 mins in a VPS with 1 CPU to run this test 🙂 I saw it reach a load of ~30 which matches the concurrency amount in the test.
Member
Thanks to both of you 🙏. In my PR, I'm lowering it to 5 parallel tests (to keep it consistent with the Go SDK). We had to reduce the amount because virtualization on MacOS runners is very slow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Erik Sipsma erik@sipsma.dev
More background on this case in the previous PR here (and in the comment included in the code of this PR): #3763
Apparently despite our expectations that being sync would stop this, @grouville hit it, so may as well just handle the error the same as we do in the Go SDK.