Skip to content

Improve releasing instructions post v0.4.0#4741

Merged
gerhard merged 1 commit into
dagger:mainfrom
gerhard:improve-releasing-post-0.4.0
Mar 13, 2023
Merged

Improve releasing instructions post v0.4.0#4741
gerhard merged 1 commit into
dagger:mainfrom
gerhard:improve-releasing-post-0.4.0

Conversation

@gerhard
Copy link
Copy Markdown
Contributor

@gerhard gerhard commented Mar 9, 2023

After going through the Engine + CLI v0.4.0 release, as well as all SDKs & docs, these improvements made sense:

  • last updated badge
  • new high-level diagram
  • convert 👉 action items to [x] checklist items
  • optimise for top to bottom consumption

The only contentious item might be the removal of post-release checks, i.e. #4461 . The manual checks are so simple - checking the dagger version output - that if we messed that up in our release process, we should add checks that would prevent a release from going through if that was to happen. Let's discuss this further in the PR.

After going through the Engine + CLI v0.4.0 release, as well as all SDKs
& docs, these improvements made sense:

- last updated badge
- new high-level diagram
- convert 👉 action items to [x] checklist items
- optimise for top to bottom consumption

The only contentious item might be the removal of post-release checks,
i.e. #4461 . The manual checks are
so simple - checking the `dagger version` output - that if we messed
that up in our release process, we should add checks that would prevent
a release from going through if that was to happen. Let's discuss this
further in the PR.

Signed-off-by: Gerhard Lazu <gerhard@dagger.io>
Copy link
Copy Markdown
Contributor

@mircubed mircubed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gerhard
Copy link
Copy Markdown
Contributor Author

gerhard commented Mar 13, 2023

Thanks @mircubed, merging.

One last cc for @sipsma re the removal of post-release checks, i.e. #4461 . Should we add checks for this in the SDK publish pipelines?

@gerhard gerhard merged commit a3b647b into dagger:main Mar 13, 2023
@gerhard gerhard deleted the improve-releasing-post-0.4.0 branch March 13, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants