feat: scrub secrets containing whitespace#4772
Merged
Merged
Conversation
dolanor
force-pushed
the
secret-whitespace-scrub
branch
from
da3ed1a to
2289128
Compare
dolanor
force-pushed
the
secret-whitespace-scrub
branch
2 times, most recently
from
7881422 to
9425b4f
Compare
dolanor
force-pushed
the
secret-whitespace-scrub
branch
2 times, most recently
from
a9f8572 to
7a588ec
Compare
dolanor
force-pushed
the
secret-whitespace-scrub
branch
2 times, most recently
from
1ea9823 to
0ce5c1d
Compare
Signed-off-by: Tanguy ⧓ Herrmann <tanguy@dagger.io>
Signed-off-by: Tanguy ⧓ Herrmann <tanguy@dagger.io>
Signed-off-by: Tanguy ⧓ Herrmann <tanguy@dagger.io>
Signed-off-by: Tanguy ⧓ Herrmann <tanguy@dagger.io>
Signed-off-by: Tanguy ⧓ Herrmann <tanguy@dagger.io>
Signed-off-by: Tanguy ⧓ Herrmann <tanguy@dagger.io>
Signed-off-by: Tanguy ⧓ Herrmann <tanguy@dagger.io>
Signed-off-by: Tanguy ⧓ Herrmann <tanguy@dagger.io>
Signed-off-by: Tanguy ⧓ Herrmann <tanguy@dagger.io>
dolanor
force-pushed
the
secret-whitespace-scrub
branch
from
0ce5c1d to
f15b065
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation is simple.
It leaks some meta information: the number of lines contained in the secret. Each line of secret data will be replaced by
***.