Add SDK label to rust#5182
Merged
Merged
Conversation
wingyplus
commented
May 23, 2023
Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
kjuulh
approved these changes
May 24, 2023
Contributor
kjuulh
left a comment
kjuulh
left a comment
There was a problem hiding this comment.
Lgtm. As mentioned in the comments I will test it as part of another app to make sure it keeps the pkg version and not the downstream one
Contributor
|
If this looks good to you @kjuulh, go for Squash and merge, e.g. 
|
Contributor
|
I still need to test the behavior I will get to it after work if that is alright xD |
Contributor
|
@gerhard @wingyplus I've just tested it. It works as it should! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found during reading SDK CONTRIBUTING.md. The rust SDK doesn't set label
dagger.io/sdk.nameanddagger.io/sdk.versionto thedagger session. This changes start by adding the SDK name label to it.