Node.js: Fix linting doc snippets#5381
Merged
Merged
Conversation
Contributor
Author
|
The failing rust actions should be fixed in: |
Merged
Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com>
Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com>
d49bf45 to
1a63844
Compare
gerhard
approved these changes
Jul 3, 2023
Contributor
gerhard
left a comment
There was a problem hiding this comment.
Nice improvements!
Is it OK to leave this as is? cc @slumbering
> yarn docs:lint
yarn run v1.22.19
$ yarn eslint --max-warnings=0 --resolve-plugins-relative-to=./ ../../docs/current
$ /Users/gerhard/github.com/dagger/dagger/sdk/nodejs/node_modules/.bin/eslint --max-warnings=0 --resolve-plugins-relative-to=./ ../../docs/current
=============
WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.
You may find that it works just fine, or you may not.
SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <5.1.0
YOUR TYPESCRIPT VERSION: 5.1.3
Please only submit bug reports when using the officially supported version.
=============
✨ Done in 3.18s.Same issue is happening even after rebasing on top of main.
Contributor
Author
|
@gerhard Yeah, we should upgrade that but I'd say it's a different PR. Not introduced by this one. |
Contributor
Author
|
This would be a downgrade actually. Probably |
Contributor
Author
|
For reference this was only closed 3 days ago: |
Contributor
|
Sounds good to me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4857
I removed the duplication in eslint and prettier configs by extending them, same as I did in Python.
So you can lint docs from
sdk/nodejsdirectory:yarn docs:lintAnd format:
yarn docs:fmt