[WIP] Add localstack test to S3 package#587
Closed
grouville wants to merge 1 commit into
Closed
Conversation
…with CI creds Signed-off-by: Guillaume de Rouville <guillaume.derouville@gmail.com>
Member
Author
|
@samalba, on the first run. The CI broke, but not related to AWS tests (Kubernetes and Docker Run) : ultra weird that it doesn't work locally using CI creds. If it works again, I'll wipe everything and start again with a clean setup |
Contributor
Yep, we've had CI issues, should be fixed now by rebasing. NOTE: you'll need to remove |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Localstack test implementation.
As I didn't rebase frequently, I need to add the S3#Sync tonight, but currently stuck by the issues cited below.
I am encountering these 2 issues :
Prerequisites :
For the LocalStack test to run, you need to have LocalStack running on port 4566 :
pip install localstack, thenlocalstack start. Once running, you also need to create thedagger-cibucket :aws --endpoint-url=http://localhost:4566 s3 mb s3://dagger-ci.