Move universe tests to universe dir#602
Merged
Merged
Conversation
Signed-off-by: Solomon Hykes <solomon@dagger.io>
Contributor
Author
|
cc @TomChv to make sure your docker run tests survived the transition. Let me know if you see anything strange |
Contributor
|
LGTM The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract (some*) universe tests from the dagger integration tests, into their own test suite.
Pros:
Cons:
universeandtests/stdlibPlease keep an open mind when weighing pros vs cons! If you are on the fence about merging, please consider a mercy “checkpoint merge” + improvement requests, to spare me the pain of manual rebase on new tests 😭
My hope is that we can use this as a starting point, then gradually use dagger more and more, and ideally replace yarn & make with
daggercompletely.