Skip to content

Move universe tests to universe dir#602

Merged
aluzzardi merged 1 commit into
dagger:mainfrom
shykes:universe-devenv
Jun 9, 2021
Merged

Move universe tests to universe dir#602
aluzzardi merged 1 commit into
dagger:mainfrom
shykes:universe-devenv

Conversation

@shykes
Copy link
Copy Markdown
Contributor

@shykes shykes commented Jun 9, 2021

Extract (some*) universe tests from the dagger integration tests, into their own test suite.

Pros:

  • Dogfooding: use dagger to develop universe. Discover exciting new bugs and UX limitations!
  • Learning: deep dive into integration tests is a great way to better understand the beast
  • Scale: universe will grow faster than dagger core: more packages, more people, more tests. The sooner we separate testing infra, the sooner we can prepare for the tsunami.
  • Simplify: slowing or even stopping growth of core integration tests will make it easier to refactor them.
  • Unify: Test data now lives within the package

Cons:

  • Dagger UX makes workflow a bit awkward (but at least now we can fix!)
  • Some duplication between universe and tests/stdlib
  • Not all tests are ported: only those with a ready-to-use env

Please keep an open mind when weighing pros vs cons! If you are on the fence about merging, please consider a mercy “checkpoint merge” + improvement requests, to spare me the pain of manual rebase on new tests 😭

My hope is that we can use this as a starting point, then gradually use dagger more and more, and ideally replace yarn & make with dagger completely.

@shykes shykes changed the title Move universe tests to universe dir [WIP] Move universe tests to universe dir Jun 9, 2021
Signed-off-by: Solomon Hykes <solomon@dagger.io>
@shykes shykes changed the title [WIP] Move universe tests to universe dir Move universe tests to universe dir Jun 9, 2021
@shykes shykes requested a review from aluzzardi June 9, 2021 20:41
@shykes
Copy link
Copy Markdown
Contributor Author

shykes commented Jun 9, 2021

cc @TomChv to make sure your docker run tests survived the transition. Let me know if you see anything strange

@aluzzardi
Copy link
Copy Markdown
Contributor

LGTM

The tests/ stuff predates gitflow and was awkwardly ported over in a rush (i.e those were the tests we needed, not the ones we deserved).

@aluzzardi aluzzardi merged commit 91eed48 into dagger:main Jun 9, 2021
@aluzzardi aluzzardi deleted the universe-devenv branch June 9, 2021 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants