ci: always print engine logs on job failure#6247
Closed
jedevc wants to merge 1 commit into
Closed
Conversation
Previously, these logging messages were only added on the publish job. This meant that failures in the engine and cli jobs didn't trigger this type of message, and so makes crashes more difficult to debug. Signed-off-by: Justin Chadwell <me@jedevc.com>
Contributor
Author
|
Right, I've just understood why we can't do this 😄 Because we just forward the socket for the dagger engine into each pod, we can't actually get the logs that are being created for the engine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, these logging messages were only added on the publish job provisioning tests:
dagger/.github/workflows/publish.yml
Lines 251 to 256 in 9a0f81a
This meant that failures in the engine and cli jobs didn't trigger this type of message, and so makes crashes more difficult to debug. We already print the kernel logs, we just don't grab the engine logs.
This would have been useful when encountering #6234 when building off of master. Some clients returned the useful buildkit panic, however, at the same time, other clients simply got a 502 error - I suspect this was the same crash that brought down the whole engine, but it's difficult to confirm this currently without the engine logs.