Skip to content

ci: always print engine logs on job failure#6247

Closed
jedevc wants to merge 1 commit into
dagger:mainfrom
jedevc:ci-print-engine-logs
Closed

ci: always print engine logs on job failure#6247
jedevc wants to merge 1 commit into
dagger:mainfrom
jedevc:ci-print-engine-logs

Conversation

@jedevc
Copy link
Copy Markdown
Contributor

@jedevc jedevc commented Dec 11, 2023

Previously, these logging messages were only added on the publish job provisioning tests:

- name: "ALWAYS print engine logs - especially useful on failure"
if: always()
run: docker logs $(docker ps -q --filter name=dagger-engine)
- name: "ALWAYS print kernel logs - especially useful on failure"
if: always()
run: sudo dmesg

This meant that failures in the engine and cli jobs didn't trigger this type of message, and so makes crashes more difficult to debug. We already print the kernel logs, we just don't grab the engine logs.

This would have been useful when encountering #6234 when building off of master. Some clients returned the useful buildkit panic, however, at the same time, other clients simply got a 502 error - I suspect this was the same crash that brought down the whole engine, but it's difficult to confirm this currently without the engine logs.

Previously, these logging messages were only added on the publish job.
This meant that failures in the engine and cli jobs didn't trigger this
type of message, and so makes crashes more difficult to debug.

Signed-off-by: Justin Chadwell <me@jedevc.com>
@jedevc jedevc requested a review from gerhard December 11, 2023 13:24
@jedevc jedevc marked this pull request as draft December 11, 2023 13:29
@jedevc jedevc closed this Dec 11, 2023
@jedevc
Copy link
Copy Markdown
Contributor Author

jedevc commented Dec 11, 2023

Right, I've just understood why we can't do this 😄

Because we just forward the socket for the dagger engine into each pod, we can't actually get the logs that are being created for the engine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant