Skip to content

improve releasing during v0.11.6#7517

Merged
sipsma merged 5 commits into
dagger:mainfrom
sipsma:improve-releasing-during-v0.11.6
Jun 5, 2024
Merged

improve releasing during v0.11.6#7517
sipsma merged 5 commits into
dagger:mainfrom
sipsma:improve-releasing-during-v0.11.6

Conversation

@sipsma
Copy link
Copy Markdown
Contributor

@sipsma sipsma commented May 30, 2024

TODO:

  • get rid of references to ./hack/make
  • clarify # Update .github/workflows dagger versions $ENGINE_VERSION and # Update docs/current_docs files to point to new dagger version steps
    • I had to do some careful grepping around (can't prefix with v to find the docs file, yamls use v0-11-5, etc.)
  • add note that homebrew-core repo may not get an automated update PR for a few hours (based on timestamps from previous release)

@jedevc jedevc force-pushed the improve-releasing-during-v0.11.6 branch from 3cf47d3 to 7e7e49f Compare June 4, 2024 10:15
@jedevc
Copy link
Copy Markdown
Contributor

jedevc commented Jun 4, 2024

@sipsma thanks for doing the release 🎉

I noticed a couple missed versions in .github so I bumped those too.

I think I did your TODOs too:

  • I removed ./hack/make references in the RELEASING.md file.
  • I also clarified the section you mentioned about updating versions in .github and docs with the exact files/formats to search for. Ideally, we need a more automated way to do this, but out-of-scope for here I think.
  • Added a note about homebrew-core.

Moving this out of draft, since I think it's ready to merge, but I'll let ya click the button 🎉 (in case I messed something up!)

@jedevc jedevc marked this pull request as ready for review June 4, 2024 10:18
@jedevc
Copy link
Copy Markdown
Contributor

jedevc commented Jun 4, 2024

Oh no - we got inconsistent graph state: https://github.com/dagger/dagger/actions/runs/9365341205/job/25780355587?pr=7517.

I thought this was fixed by the upstream buildkit work 😢

@sipsma
Copy link
Copy Markdown
Contributor Author

sipsma commented Jun 4, 2024

Oh no - we got inconsistent graph state: https://github.com/dagger/dagger/actions/runs/9365341205/job/25780355587?pr=7517.

I thought this was fixed by the upstream buildkit work 😢

😢 indeed, though I technically only ever repro'd and verified a fix for the other error (failed to get state for edge), the connection to inconsistent graph state was purely theoretical. So I'll allow myself the cope that at least the other error seems to be squashed (was way more common than inconsistent graph state)...

sipsma and others added 5 commits June 4, 2024 20:18
Signed-off-by: Erik Sipsma <erik@sipsma.dev>
Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
@sipsma sipsma force-pushed the improve-releasing-during-v0.11.6 branch from bc634cd to c64f795 Compare June 5, 2024 03:18
@sipsma sipsma merged commit 0be1329 into dagger:main Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants