chore: add DAGGER_COMMIT option to install.sh#7544
Conversation
This allows installing an arbitrary commit from main, to make it easier to install versions from main for testing. Signed-off-by: Justin Chadwell <me@jedevc.com>
|
fyi @shykes |
Signed-off-by: Justin Chadwell <me@jedevc.com>
| $version = "v" + (latest_version) | ||
| } | ||
| $fileName="dagger_v" + $version + "_windows_amd64" | ||
| $fileName="dagger_" + $version + "_windows_amd64" |
There was a problem hiding this comment.
I thought this PR was only for .sh but can you check my PR maybe for some improvements i.e:
- The amd64 is fixed here but Windows runs ARM too WinRT
- The $InteractiveInstall could be a
[switch]for a cleaner looking.\script -Install(no bool)
you can close mine if some of my changes can improve this one enough?
There was a problem hiding this comment.
Thanks @pjmagee for #7569, they look pretty good to me!
I think both PRs do something different, this is just adding a new feature into both scripts to make it easier to consume builds from main. I think my idea is to try and merge this one first, and then we can rebase #7569 on top of that with changes?
There was a problem hiding this comment.
yeah, Lets do that. Though I do actually notice now that the .ps1 script was looking as close as possible to the .sh script. If thats a conscious decision by the dagger team, maybe my PR is not a good idea?
There was a problem hiding this comment.
The keeping it inline was mostly just me attempting to tidy up the windows script when I reimported it - there's no issue if you want to diverge IMO, if that's more familiar to windows users 🎉
|
Taking a look at this now. |
There was a problem hiding this comment.
Code changes look right to me. I also checked that:
-
./install.shinstalls latest released version -
DAGGER_VERSION=v0.11.5 ./install.shinstalls specific version -
DAGGER_COMMIT=2cbda9c7547809a35eb93ff7677e5bab4afd00c1 ./install.shinstalls dev version -
DAGGER_COMMIT=2cbda9c ./install.shfails as expected (full git sha is required)
LGTM 👍 🚀
After this gets merged, DM me @jedevc so that I can do the CloudFront dance 🕺
3 participants
This allows installing an arbitrary commit from main, to make it easier to install versions from main for testing.
TODO:
install.ps1changes on windows