chore: update alpine base to 3.20#7562
Conversation
There was a problem hiding this comment.
super nitpick: this will give a failure like false is not true which isn't very helpful, might be better to assert against distconsts.AlpineVersion+"\n"
not blocking, since these tests probably won't start failing anyway
There was a problem hiding this comment.
🎉 Fixed this up now!
gerhard
left a comment
gerhard
left a comment
There was a problem hiding this comment.
LGTM 💪 🚀
Left a few comments which can be addressed as follow-ups, no need to hold this.
There was a problem hiding this comment.
Should we bump this to 1.22.4 so that we benefit from the latest security fixes?
There was a problem hiding this comment.
Should we bump this to 1.21.11 so that we benefit from the latest security fixes?
There was a problem hiding this comment.
Removed this, 1.22.4 includes a backport to fix the runc issue we were seeing, so this isn't needed anymore. cc @vito
Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
Also, we can remove the runc hack - go 1.22.4 includes a backported fix for the pthreads issue that upstream was encountering. Signed-off-by: Justin Chadwell <me@jedevc.com>
3 participants
Revival of #7323.
This is motivated slightly by some of the issues in #7554 - running up-to-date software is pretty important.