Conversation
Contributor
|
This PR isn't exactly what we wanted due to the fact that we are creating a release off a patch branch for the first time. We do want this PR to end up in main, but first want this sdk bump to get merged into the For now, will just go manually create that separately and come back to this PR once the release is done. |
This was referenced Jun 24, 2024
sipsma
changed the title
Signed-off-by: Erik Sipsma <erik@sipsma.dev>
Signed-off-by: Dagger CI <hello@dagger.io>
Signed-off-by: Erik Sipsma <erik@sipsma.dev>
Signed-off-by: Erik Sipsma <erik@sipsma.dev>
Signed-off-by: Erik Sipsma <erik@sipsma.dev>
Signed-off-by: Erik Sipsma <erik@sipsma.dev>
jedevc
approved these changes
Jun 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(edits from sipsma)
As mentioned in the comment below, ended up having to manually make the bump PR for the
release-v0.11.9branch since this automated PR doesn't handle that whole non-main-branch workflow yet.There were a few other commits from that branch that needed forward-porting, so I'm just reusing this PR for all of them. They are all cherry-picked from that branch (though needed some manual conflict resolution for a few files due to divergence on main, so not exact diff match).
Also snuck in a fix to CHANGELOG.md for the PR link, which was pointed out after the release to be to the wrong PR.