chore: restore default view to top-level dagger module#7805
Closed
shykes wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Solomon Hykes <solomon@dagger.io>
Contributor
|
I'm reasonably sure that the views are defined by the module that's being called. I don't think they're defined by the directory being loaded. If the view wasn't being fetched correctly, we'd see an error message for it |
Contributor
Author
|
I think you're right... That's not how I intended views to work, it seems there was a big misunderstanding at implementation. Anyway views will be effectively deprecated by context directory, so this should take care of itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #7766 we moved
dagger.jsonfrom./to./dev/. But we forgot to leave theviewsbehind - those apply specifically to the root of the repo.