Skip to content

chore: restore default view to top-level dagger module#7805

Closed
shykes wants to merge 1 commit into
dagger:mainfrom
shykes:views
Closed

chore: restore default view to top-level dagger module#7805
shykes wants to merge 1 commit into
dagger:mainfrom
shykes:views

Conversation

@shykes
Copy link
Copy Markdown
Contributor

@shykes shykes commented Jul 2, 2024

In #7766 we moved dagger.json from ./ to ./dev/. But we forgot to leave the views behind - those apply specifically to the root of the repo.

Signed-off-by: Solomon Hykes <solomon@dagger.io>
@jedevc
Copy link
Copy Markdown
Contributor

jedevc commented Jul 2, 2024

I'm reasonably sure that the views are defined by the module that's being called. I don't think they're defined by the directory being loaded.

If the view wasn't being fetched correctly, we'd see an error message for it failed to get view: view "default" not found (which we're not seeing).

@shykes
Copy link
Copy Markdown
Contributor Author

shykes commented Jul 2, 2024

I think you're right... That's not how I intended views to work, it seems there was a big misunderstanding at implementation.

Anyway views will be effectively deprecated by context directory, so this should take care of itself.

@shykes shykes closed this Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants