Skip to content

github: upload dev engine logs#7933

Merged
vito merged 1 commit into
dagger:mainfrom
vito:testdev-engine-logs
Jul 16, 2024
Merged

github: upload dev engine logs#7933
vito merged 1 commit into
dagger:mainfrom
vito:testdev-engine-logs

Conversation

@vito
Copy link
Copy Markdown
Contributor

@vito vito commented Jul 15, 2024

Seeing some runs that seem to hang for a while after they supposedly complete. Ideally we could do this for all jobs, not just testdev, but it's easy to start with it.

note: thought about making this only run on failure, but it seems like we can just do it always; the .zip is ~7MB for a successful run and afaik doesn't cost us anything.

@vito vito changed the title github: capture and upload engine logs on failure github: upload dev engine logs Jul 15, 2024
Signed-off-by: Alex Suraci <alex@dagger.io>
@vito vito force-pushed the testdev-engine-logs branch from 6cedba4 to 0046588 Compare July 15, 2024 21:03
@vito vito requested a review from gerhard July 15, 2024 21:32
@vito vito marked this pull request as ready for review July 15, 2024 21:48
@vito vito requested review from helderco and sipsma July 16, 2024 17:53
@grouville grouville self-requested a review July 16, 2024 18:04
Copy link
Copy Markdown
Member

@grouville grouville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vito vito merged commit a3af9ae into dagger:main Jul 16, 2024
@vito vito deleted the testdev-engine-logs branch July 16, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants