ci: fix go linter#7950
Merged
Merged
Conversation
shykes
reviewed
Jul 17, 2024
jedevc
force-pushed
the
fix-go-linter
branch
3 times, most recently
from
9f6b1c2 to
041e42a
Compare
There are two issues: - Some errors have an empty "Severity" - not entirely sure why, but some of the code was handling this correctly, but Assert wasn't. - The GOLANGCI_LINT_CONFIG doesn't seem to have been being respected, I can't find any reference to it. So we can just use the suggested use of from the docs. Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Solomon Hykes <solomon@dagger.io>
These were missed earlier, because of a misconfiguration in the linting pipeline Signed-off-by: Solomon Hykes <solomon@dagger.io>
Contributor
|
I am trying to test this, but golangci-lint just runs and runs, and eventually times out. Can anyone else reproduce? dagger call \
-m github.com/dagger/dagger/dev@pull/7950/merge \
--source https://github.com/dagger/dagger#pull/7950/merge \
engine \
lint |
shykes
approved these changes
Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed in #7872 (comment)
There are two issues:
GOLANGCI_LINT_CONFIGdoesn't seem to have been being respected, I can't find any reference to it. So we can just use the suggested use of from the docs.