chore: increase verbosity of codegen error even more#8214
Merged
marcosnils merged 3 commits intoAug 28, 2024
Merged
Conversation
jedevc
force-pushed
the
improve-default-codegen-message-verbosity-more
branch
from
46f2464 to
9ced596
Compare
Signed-off-by: Justin Chadwell <me@jedevc.com>
This fixes a weird code path where we would get a subdirectory of the memfs when we didn't need to. Signed-off-by: Justin Chadwell <me@jedevc.com>
These were actually not being totally inclusive of everything we use, which was meaning that go-imports was essentially randomly deciding some important dependencies - this probably wasn't helping our performance/predictability. Signed-off-by: Justin Chadwell <me@jedevc.com>
jedevc
force-pushed
the
improve-default-codegen-message-verbosity-more
branch
from
9ced596 to
bbbf31b
Compare
marcosnils
approved these changes
Aug 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #8181 (as part of the investigation along #8207)
And some other weird fixes in the area that probably needed doing.