update cache volume type hints to show npm cache instead of node_modules#8719
Merged
jedevc merged 1 commit intoDec 4, 2024
Conversation
marcosnils
approved these changes
Oct 16, 2024
Contributor
|
Could you please check the failing tests @kpenfound ? Thanks |
Contributor
|
Hm, should our graphql docs (which end up in the doc comments) have language specific examples at all? |
Contributor
Author
|
@jedevc good point, should it maybe just be "Location of the cache directory"? |
Contributor
|
Yup that sounds good to me 🎉 |
Contributor
|
@kpenfound quick ping on this, can we merge it? |
Contributor
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
jedevc
force-pushed
the
kyle/eco-378-dont-suggest-using-a-cache-volume-with-node_modules-in-docs
branch
from
7d8768f to
6b6d59a
Compare
jedevc
approved these changes
Nov 20, 2024
jedevc
force-pushed
the
kyle/eco-378-dont-suggest-using-a-cache-volume-with-node_modules-in-docs
branch
from
6b6d59a to
b9d960b
Compare
Contributor
|
Oops, |
Contributor
|
@jedevc @kpenfound any objections to merging this? |
vikram-dagger
approved these changes
Dec 4, 2024
Signed-off-by: kpenfound <kyle@dagger.io>
jedevc
force-pushed
the
kyle/eco-378-dont-suggest-using-a-cache-volume-with-node_modules-in-docs
branch
from
b9d960b to
81da622
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from #8627